Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality for zoom in\out by sliding the wheel #52

Conversation

OmriGM
Copy link
Contributor

@OmriGM OmriGM commented Dec 20, 2020

Listening to wheel event the determine the direction of the scrolling, and by that decide if zooming in or out.

This PR was opened due to this Feature Request in Ant Design repository's issues:
ant-design/ant-design#28415

After this PR will be merged and a new version will be released I'll open a PR for Ant Design to integrate this new feature.

omri.g added 2 commits December 20, 2020 16:40
…to wheel event the determine the direction of the scrolling, and by that decide if zooming in or out.
@vercel
Copy link

vercel bot commented Dec 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/image/kzjd59b8q
✅ Preview: https://image-git-fork-omrigm-feature-wheel-event-zoom-image-preview.react-component.vercel.app

@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #52 (f900a46) into master (92b055f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #52   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          206       220   +14     
  Branches        54        57    +3     
=========================================
+ Hits           206       220   +14     
Impacted Files Coverage Δ
src/Preview.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b055f...f900a46. Read the comment docs.

src/Preview.tsx Outdated Show resolved Hide resolved
src/Preview.tsx Show resolved Hide resolved
src/Preview.tsx Outdated Show resolved Hide resolved
@OmriGM
Copy link
Contributor Author

OmriGM commented Dec 21, 2020

@shaodahong
Lint errors aren't related to any change I did to the code

src/Preview.tsx Outdated Show resolved Hide resolved
src/Preview.tsx Outdated Show resolved Hide resolved
@shaodahong
Copy link
Member

+ rc-image@4.4.0

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants